Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings): build on windows #183

Merged
merged 15 commits into from
Oct 11, 2022
Merged

fix(bindings): build on windows #183

merged 15 commits into from
Oct 11, 2022

Conversation

OrangeSodahub
Copy link
Contributor

@OrangeSodahub OrangeSodahub commented Oct 9, 2022

  • Update version of fusefilter.h.
  • Fix __umulh not defined (MSVC on win-64bit).
  • Fix error C2540 (MSVC on win-64bit).
  • Add ci/cd for windows.
  • Fix unittest on windows.

@OrangeSodahub OrangeSodahub marked this pull request as ready for review October 9, 2022 09:35
@OrangeSodahub OrangeSodahub marked this pull request as draft October 9, 2022 09:35
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #183 (c270f93) into main (02857ec) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   81.74%   81.65%   -0.09%     
==========================================
  Files          20       20              
  Lines        1172     1172              
==========================================
- Hits          958      957       -1     
- Misses        214      215       +1     
Flag Coverage Δ
annlite 81.65% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
annlite/storage/table.py 96.01% <100.00%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@numb3r3
Copy link
Member

numb3r3 commented Oct 9, 2022

@OrangeSodahub Please also enable window runner in .github/workflows/ci.yml and .github/workflows/cd.yml. And for more details, please refer to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

@OrangeSodahub OrangeSodahub changed the title fix: build on windows fix(cppbindings): build on windows Oct 9, 2022
@numb3r3 numb3r3 changed the title fix(cppbindings): build on windows fix(bindings): build on windows Oct 10, 2022
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also enable window runner in .github/workflows/ci.yml and .github/workflows/cd.yml. And for more details, please refer to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

@OrangeSodahub OrangeSodahub force-pushed the fix-build-on-windows branch 2 times, most recently from 1f3366b to c60c84a Compare October 10, 2022 13:30
@OrangeSodahub
Copy link
Contributor Author

OrangeSodahub commented Oct 11, 2022

Four problems:

  • file name contains : not allowed.
  • Pod was forced to close after 1 second. Graceful closing is not available on Windows.
  • UnicodeEncodeError
  • test_meta_table

@numb3r3
Copy link
Member

numb3r3 commented Oct 11, 2022

.github/workflows/cd.yml Outdated Show resolved Hide resolved
@OrangeSodahub
Copy link
Contributor Author

OrangeSodahub commented Oct 11, 2022

On Windows, two adjacent calls of datetime.datetime.utcnow() could generate the two same time.

time_since = datetime.datetime.utcnow()
table.add_address('0', 1, 2)
addr = table.get_latest_commit()
print(time_since)
print(addr[-1])

Then output:

2022-10-11 08:44:25.068751
2022-10-11 08:44:25.068751

So I change some > to >= to make it passed.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@numb3r3 numb3r3 marked this pull request as ready for review October 11, 2022 09:06
@numb3r3 numb3r3 merged commit bb402ae into main Oct 11, 2022
@numb3r3 numb3r3 deleted the fix-build-on-windows branch October 11, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants