-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bindings): build on windows #183
Conversation
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 81.74% 81.65% -0.09%
==========================================
Files 20 20
Lines 1172 1172
==========================================
- Hits 958 957 -1
- Misses 214 215 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@OrangeSodahub Please also enable window runner in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also enable window runner in .github/workflows/ci.yml and .github/workflows/cd.yml. And for more details, please refer to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
1f3366b
to
c60c84a
Compare
97c299e
to
1df1e57
Compare
Four problems:
|
@OrangeSodahub About the UnicodeError, please refer to https://docs.jina.ai/get-started/install/windows/#unicodeencodeerror-on-jina-cli |
On Windows, two adjacent calls of time_since = datetime.datetime.utcnow()
table.add_address('0', 1, 2)
addr = table.get_latest_commit()
print(time_since)
print(addr[-1]) Then output: 2022-10-11 08:44:25.068751
2022-10-11 08:44:25.068751 So I change some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
fusefilter.h
.__umulh
not defined (MSVC on win-64bit).C2540
(MSVC on win-64bit).