feat: add SpellChecker #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianmtr
force-pushed
the
feat-init-pr
branch
from
ac27c6d
to
271e233
Compare
3 tasks
cristianmtr
force-pushed
the
feat-init-pr
branch
10 times, most recently
from
691d4e3
to
be1c46d
Compare
cristianmtr
force-pushed
the
feat-init-pr
branch
from
be1c46d
to
6a442f7
Compare
nan-wang
requested changes
Oct 17, 2021
Co-authored-by: Nan Wang <nan.wang@jina.ai>
nan-wang
requested changes
Oct 18, 2021
cristianmtr
force-pushed
the
feat-init-pr
branch
2 times, most recently
from
ad0625a
to
8eda16e
Compare
cristianmtr
force-pushed
the
feat-init-pr
branch
from
8eda16e
to
6876386
Compare
cristianmtr
force-pushed
the
feat-init-pr
branch
2 times, most recently
from
c7ae750
to
eb601cd
Compare
nan-wang
requested changes
Oct 19, 2021
cristianmtr
force-pushed
the
feat-init-pr
branch
from
eb601cd
to
38f3dce
Compare
cristianmtr
force-pushed
the
feat-init-pr
branch
from
38f3dce
to
574b969
Compare
|
@nan-wang The dockerfile is required. Otherwise it seems hubble push fails https://github.com/jina-ai/executor-spellchecker/runs/3936376198?check_suite_focus=true#step:6:200 |
jakobkruse1
reviewed
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial PR for SpellChecker Executor
TODO