Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added unit and integration tests #3

Merged
merged 2 commits into from
Sep 30, 2021
Merged

test: added unit and integration tests #3

merged 2 commits into from
Sep 30, 2021

Conversation

makram93
Copy link
Member

Added unit tests and the integration test.

@makram93 makram93 marked this pull request as ready for review September 29, 2021 22:53
tadejsv
tadejsv reviewed Sep 30, 2021
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
cristianmtr
cristianmtr approved these changes Sep 30, 2021
View reviewed changes
Copy link

@cristianmtr cristianmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tadejsv
tadejsv approved these changes Sep 30, 2021
View reviewed changes
Copy link

@tadejsv tadejsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makram93 makram93 merged commit 3b56cd7 into main Sep 30, 2021
@makram93 makram93 mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadejsv tadejsv tadejsv approved these changes

@cristianmtr cristianmtr cristianmtr approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makram93 @cristianmtr @tadejsv