-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 86.99% 87.92% +0.93%
==========================================
Files 30 35 +5
Lines 1668 1781 +113
==========================================
+ Hits 1451 1566 +115
+ Misses 217 215 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finetuner/tuner/metrics.py
is redundant to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@hanxiao can you review the changes wrt the |
First attempt on Evaluation with our dataset. Missing: