This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
feat: options for miner and optimizer #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenthermi
requested review from
jupyterjazz,
gmastrapas and
bwanglzu
and removed request for
jupyterjazz
github-actions
bot
added
size/s
area/core
area/docs
area/entrypoint
area/testing
guenthermi
changed the title
bwanglzu
reviewed
Aug 30, 2022
| @@ -59,6 +62,7 @@ run = finetuner.fit( | |||
| model_options={}, # additional options to pass to the model constructor | |||
| loss='TripletMarginLoss', # Use CLIPLoss for CLIP fine-tuning. | |||
| miner='TripletMarginMiner', | |||
| miner_options={'margin': 0.2}, # additional options for the miner constructor | |||
There was a problem hiding this comment.
can you add optimizer options to here?
bwanglzu
reviewed
Aug 30, 2022
| To filter the instances in a batch that are used to calculate the loss, you can use miners. | ||
| Finetuner allows you to use miners provided by the [Pytorch Metric Learning](https://kevinmusgrave.github.io/pytorch-metric-learning) framework. | ||
| To select a specific miner, you can pass its name to the fit function, e.g., `AngularMiner`, `TripletMarginMiner`, ... |
There was a problem hiding this comment.
you can list all miners to the developer reference field, all documented in docstring
There was a problem hiding this comment.
First I had this, but it looked ugly, because the names are so long and therefore, the list is very long.
|
📝 Docs are deployed on https://ft-feat-options-for-miner-and-optimizer--jina-docs.netlify.app 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for miner and optimizer options and documentation about optimizers and miners.
Addresses #299 and #300