Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

feat: add error message when experiment is None #708

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented Apr 5, 2023

This pr checks if experiment has successfully been set before starting a run, and will raise a ValueError if not.


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@LMMilliken LMMilliken changed the title feat: add error message when experiment is feat: add error message when experiment is None Apr 5, 2023
finetuner/finetuner.py Outdated Show resolved Hide resolved
finetuner/finetuner.py Outdated Show resolved Hide resolved
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative 👍 This error has confused so much users already.

raise ValueError(
(
'Unable to start finetuning run as experiment is `None`. '
'Make sure you have logged in using `finetuner.login()`.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add the force flag. I think this is more robust.

@LMMilliken LMMilliken merged commit 3fb9658 into main Apr 5, 2023
@LMMilliken LMMilliken deleted the refactor-improve-err-message branch April 5, 2023 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants