Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

co-op demo with mindspore #431

Closed
hanxiao opened this issue May 19, 2020 · 8 comments · Fixed by #836
Closed

co-op demo with mindspore #431

hanxiao opened this issue May 19, 2020 · 8 comments · Fixed by #836
Labels
type/feature-request This issue describes a new feature or behaviour a user or users desires.

Comments

@hanxiao
Copy link
Member

hanxiao commented May 19, 2020

Describe the feature
port one cv demo into jina using mindspore

Your proposal
ref. https://www.mindspore.cn/tutorial/en/master/advanced_use/computer_vision_application.html?highlight=feature

Implement two encoders, one in NLP, one in CV with Mindspore and add them to the executor family of Jina.

Would be great if anyone can provide some pretrained models, this will greatly speedup the dev process and onboarding for new developers.

No. Task Description Issue ID
1 CV model
2 NLP model
3 Add a tutorial to examples

Environment

Screenshots

@hanxiao hanxiao added the type/feature-request This issue describes a new feature or behaviour a user or users desires. label May 19, 2020
@nan-wang nan-wang modified the milestones: v0.3.0, v0.4.0 May 22, 2020
@jina-bot
Copy link
Member

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days

@jina-bot jina-bot added the Stale label Jun 12, 2020
@hanxiao hanxiao reopened this Jun 21, 2020
@alexcg1
Copy link
Member

alexcg1 commented Jun 23, 2020

Are we in touch with Mindspore already? If not I can reach out

@hanxiao
Copy link
Member Author

hanxiao commented Jun 23, 2020

The mindspore team is working on refactoring their modelzoo. Last time they suggested me to wait until their model zoo is stable.

I'm in the mindspore TSC, we keep in good contact.

@hanxiao hanxiao removed the Stale label Jun 23, 2020
@jina-bot
Copy link
Member

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days

@jina-bot jina-bot added the Stale label Jul 14, 2020
@nan-wang nan-wang removed the Stale label Jul 14, 2020
@nan-wang
Copy link
Member

nan-wang commented Jul 17, 2020

image
OS X support is still missing from mindspore side. It seems that their main target platforms are Ubuntu, Windows, and EulerOS

Reference:
https://gitee.com/mindspore/mindspore/issues/I1DA2C?from=project-issue

@nan-wang
Copy link
Member

nan-wang commented Jul 17, 2020

Unfortunately, mindspore.model_zoo provides the implementations of various classic DL models rather than the trained ones. The users will need to train the model. :(

Do they have any plan to host the pretrained models? Otherwise, we can only provide a simple BaseMindsporeEncoder @hanxiao

Reference:
https://github.com/mindspore-ai/mindspore/tree/master/model_zoo

@hanxiao
Copy link
Member Author

hanxiao commented Jul 17, 2020

trained or no trained, it is just a checkpoint. We don't unit test those models anyway in Jina core. A simple MindsporeModel wrapper would be sufficient for accomplishing this issue.

@jina-bot
Copy link
Member

jina-bot commented Aug 7, 2020

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 4 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request This issue describes a new feature or behaviour a user or users desires.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants