Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor request test #1445

Merged
merged 2 commits into from
Dec 12, 2020
Merged

test: refactor request test #1445

merged 2 commits into from
Dec 12, 2020

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Dec 11, 2020

Add missing tests for types.Request.

@bwanglzu bwanglzu self-assigned this Dec 11, 2020
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Dec 11, 2020
@bwanglzu bwanglzu marked this pull request as ready for review December 11, 2020 22:33
@bwanglzu bwanglzu requested a review from a team as a code owner December 11, 2020 22:33
@github-actions
Copy link

github-actions bot commented Dec 11, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 2300, delta to last 3 avg.: +0%
  • 🐎🐎🐎🐎 query QPS at 54, delta to last 3 avg.: +31%

Breakdown

Version Index QPS Query QPS
current 2300 54
0.8.3 2336 41
0.8.2 2328 40
0.8.1 2244 41

Backed by latency-tracking. Further commits will update this comment.

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1941, delta to last 3 avg.: +16%
  • 🐎🐎🐎🐎 query QPS at 34, delta to last 3 avg.: +21%

Breakdown

Version Index QPS Query QPS
current 1941 34
0.8.3 1651 27
0.8.2 1676 28
0.8.1 1667 28

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1445 (3b05573) into master (6fdfb5e) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
+ Coverage   81.49%   81.75%   +0.26%     
==========================================
  Files         113      112       -1     
  Lines        6694     6650      -44     
==========================================
- Hits         5455     5437      -18     
+ Misses       1239     1213      -26     
Impacted Files Coverage Δ
jina/logging/sse.py 94.11% <0.00%> (-1.05%) ⬇️
jina/logging/profile.py 55.81% <0.00%> (-0.66%) ⬇️
jina/executors/decorators.py 87.77% <0.00%> (-0.53%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
jina/executors/evaluators/rank/precision.py 100.00% <0.00%> (ø)
jina/drivers/evaluate.py 98.21% <0.00%> (+0.03%) ⬆️
jina/peapods/peas/__init__.py 90.61% <0.00%> (+0.03%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fdfb5e...3b05573. Read the comment docs.

@hanxiao hanxiao merged commit 906c62c into master Dec 12, 2020
@hanxiao hanxiao deleted the test-refactor-request branch December 12, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants