Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): add version to grpcio package #1457

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 14, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 14, 2020 10:23
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/docker This issue/PR affects the docker functionality area/setup This issue/PR affects setting up Jina component/logging labels Dec 14, 2020
@github-actions
Copy link

github-actions bot commented Dec 14, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1904, delta to last 3 avg.: -1%
  • 🐎🐎🐎🐎 query QPS at 39, delta to last 3 avg.: +11%

Breakdown

Version Index QPS Query QPS
current 1904 39
0.8.3 1950 34
0.8.2 1912 34

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/docs This issue/PR affects the docs area/housekeeping This issue/PR is housekeeping component/resource and removed size/XS labels Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #1457 (225a6b8) into master (46aaa5b) will increase coverage by 1.48%.
The diff coverage is 96.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   81.43%   82.92%   +1.48%     
==========================================
  Files         112      108       -4     
  Lines        6616     6376     -240     
==========================================
- Hits         5388     5287     -101     
+ Misses       1228     1089     -139     
Impacted Files Coverage Δ
jina/clients/sugary_io.py 100.00% <ø> (ø)
jina/peapods/peas/gateway/rest/__init__.py 93.87% <93.87%> (ø)
jina/peapods/peas/gateway/grpc/__init__.py 92.15% <94.59%> (+14.60%) ⬆️
jina/logging/profile.py 67.50% <97.05%> (+11.02%) ⬆️
jina/clients/helper.py 80.00% <100.00%> (ø)
jina/clients/request.py 90.76% <100.00%> (ø)
jina/docker/hubio.py 71.91% <100.00%> (ø)
jina/excepts.py 100.00% <100.00%> (ø)
jina/helloworld/helper.py 91.48% <100.00%> (ø)
jina/logging/sse.py 91.42% <100.00%> (-0.51%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d44cce6...2c14ee7. Read the comment docs.

@hanxiao hanxiao merged commit 2af6d28 into master Dec 14, 2020
@hanxiao hanxiao deleted the fix-grpcio-version branch December 14, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/docker This issue/PR affects the docker functionality area/docs This issue/PR affects the docs area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina component/logging component/resource size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants