Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): handle request exception on client #1458

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 14, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 14, 2020 13:18
@jina-bot jina-bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod labels Dec 14, 2020
@github-actions
Copy link

github-actions bot commented Dec 14, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1897, delta to last 3 avg.: +1%
  • 🐎🐎 query QPS at 34, delta to last 3 avg.: +9%

Breakdown

Version Index QPS Query QPS
current 1897 34
0.8.5 1929 31
0.8.3 1819 30

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added size/M area/cicd This issue/PR affects the cicd pipeline area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping and removed size/S labels Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #1458 (9c97943) into master (7c8f916) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1458      +/-   ##
==========================================
+ Coverage   82.80%   82.99%   +0.18%     
==========================================
  Files         108      108              
  Lines        6310     6380      +70     
==========================================
+ Hits         5225     5295      +70     
  Misses       1085     1085              
Impacted Files Coverage Δ
jina/parser.py 86.28% <ø> (ø)
jina/peapods/peas/gateway/grpc/async_call.py 97.91% <ø> (+4.16%) ⬆️
jina/clients/request.py 91.30% <100.00%> (+0.53%) ⬆️
jina/logging/sse.py 91.42% <0.00%> (-0.76%) ⬇️
jina/executors/decorators.py 87.77% <0.00%> (-0.53%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
jina/executors/evaluators/rank/precision.py 100.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9f4c9...9c97943. Read the comment docs.

@hanxiao hanxiao merged commit 95178b0 into master Dec 14, 2020
@hanxiao hanxiao deleted the fix-req-generator-client branch December 14, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants