Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(io): fix input_files/lines data_type #1473

Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix(io): fix input_files/lines data_type #1473

merged 1 commit into from
Dec 17, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 17, 2020

fix problem in master also the test failure in #1426

@hanxiao hanxiao requested a review from a team as a code owner December 17, 2020 06:25
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client component/flow labels Dec 17, 2020
@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 2005, delta to last 3 avg.: -4%
  • 🐎🐎 query QPS at 39, delta to last 3 avg.: +10%

Breakdown

Version Index QPS Query QPS
current 2005 39
0.8.7 2089 35
0.8.6 2076 34
0.8.5 2104 35

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1473 (4a49127) into master (08fa53e) will increase coverage by 0.29%.
The diff coverage is 87.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1473      +/-   ##
==========================================
+ Coverage   82.76%   83.05%   +0.29%     
==========================================
  Files         110      110              
  Lines        6381     6514     +133     
==========================================
+ Hits         5281     5410     +129     
- Misses       1100     1104       +4     
Impacted Files Coverage Δ
jina/flow/asyncio.py 59.37% <23.07%> (+1.31%) ⬆️
jina/helloworld/components.py 96.42% <92.85%> (-3.58%) ⬇️
jina/clients/sugary_io.py 95.83% <100.00%> (-4.17%) ⬇️
jina/drivers/querylang/queryset/helper.py 92.30% <100.00%> (-0.55%) ⬇️
jina/excepts.py 100.00% <100.00%> (ø)
jina/helloworld/__init__.py 100.00% <100.00%> (ø)
jina/helloworld/helper.py 95.60% <100.00%> (+4.11%) ⬆️
jina/parser.py 86.40% <100.00%> (+0.11%) ⬆️
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0c489...ab4ae51. Read the comment docs.

@hanxiao hanxiao merged commit d68af45 into master Dec 17, 2020
@hanxiao hanxiao deleted the fix-input-lines branch December 17, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client component/flow size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants