Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(helper): move namespace helper into one place #1489

Merged
merged 1 commit into from
Dec 18, 2020
Merged

refactor(helper): move namespace helper into one place #1489

merged 1 commit into from
Dec 18, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 18, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 18, 2020 17:26
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/peapod labels Dec 18, 2020
@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 2141, delta to last 3 avg.: -3%
  • 😶 query QPS at 39, delta to last 3 avg.: +3%

Breakdown

Version Index QPS Query QPS
current 2141 39
0.8.8 2180 37
0.8.7 2180 37
0.8.6 2286 37

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit d2bfd6c into master Dec 18, 2020
@hanxiao hanxiao deleted the refactor-namespace-helpers branch December 18, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang Awaiting requested review from nan-wang

@rutujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/peapod size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot