Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make lint flake8 independent step #1507

Merged
merged 2 commits into from
Dec 21, 2020
Merged

ci: make lint flake8 independent step #1507

merged 2 commits into from
Dec 21, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 20, 2020

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner December 20, 2020 12:06
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Dec 20, 2020
@github-actions
Copy link

github-actions bot commented Dec 20, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1873, delta to last 3 avg.: -4%
  • 😶 query QPS at 34, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1873 34
0.8.11 1887 36
0.8.10 1970 35
0.8.9 2005 34

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #1507 (b63aa28) into master (b91f1b7) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
+ Coverage   84.16%   84.44%   +0.27%     
==========================================
  Files         106      106              
  Lines        6118     6183      +65     
==========================================
+ Hits         5149     5221      +72     
+ Misses        969      962       -7     
Impacted Files Coverage Δ
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/executors/indexers/cache.py 100.00% <0.00%> (ø)
jina/executors/evaluators/text/length.py 100.00% <0.00%> (ø)
jina/executors/evaluators/rank/precision.py 100.00% <0.00%> (ø)
jina/drivers/evaluate.py 98.21% <0.00%> (+0.03%) ⬆️
jina/docker/hubio.py 69.55% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.52% <0.00%> (+0.09%) ⬆️
jina/jaml.py 91.66% <0.00%> (+0.11%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91f1b7...9cf8ef5. Read the comment docs.

@JoanFM
Copy link
Member Author

JoanFM commented Dec 20, 2020

@hanxiao if accepted, how can I have the flake8 analysis as a required step?

@hanxiao
Copy link
Member

hanxiao commented Dec 21, 2020

why separate it from the main ci jobs?

@JoanFM
Copy link
Member Author

JoanFM commented Dec 21, 2020

why separate it from the main ci jobs?

no big deal, to have only one and not one per version

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@hanxiao hanxiao merged commit aa879d8 into master Dec 21, 2020
@hanxiao hanxiao deleted the lint-flake8-step branch December 21, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants