Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helloworld): hello-world evaluator use running avg directly #1508

Merged
merged 2 commits into from
Dec 20, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 20, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 20, 2020 17:04
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/testing This issue/PR affects testing component/driver component/resource labels Dec 20, 2020
@hanxiao hanxiao linked an issue Dec 20, 2020 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Dec 20, 2020

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1664, delta to last 3 avg.: -8%
  • 😶 query QPS at 28, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1664 28
0.8.9 1749 27
0.8.8 1831 28
0.8.7 1880 30

Backed by latency-tracking. Further commits will update this comment.

@JoanFM
Copy link
Member

JoanFM commented Dec 20, 2020

I think is not a good idea to encourage to use this feature. it is impossible to reset and leads to stateful computations.

@JoanFM
Copy link
Member

JoanFM commented Dec 20, 2020

Plus this feature goes against the idea of having the ability of having a contunious Flow instance running. We have no way to reset the running average (and I think we should not have one for now)

@github-actions
Copy link

Thanks for your contribution ❤️
💔 Unfortunately, this PR has one ore more bad commit messages, it can not be merged. To fix this problem, please refer to:

Note, other CI tests will not start until the commit messages get fixed.

This message will be deleted automatically when the commit messages get fixed.

@hanxiao hanxiao merged commit ceff8ef into master Dec 20, 2020
@hanxiao hanxiao deleted the fix-running-avg branch December 20, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helloworld This issue/PR affects the helloworld area/testing This issue/PR affects testing component/driver component/resource size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add README section for hello-world evaluation
3 participants