Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): fix flow cls register #1516

Merged
merged 4 commits into from
Dec 21, 2020
Merged

fix(flow): fix flow cls register #1516

merged 4 commits into from
Dec 21, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Dec 21, 2020

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner December 21, 2020 16:21
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/flow labels Dec 21, 2020
@deepankarm
Copy link
Contributor

Should we allow to load a Flow from a string based yaml? This can be useful in jinad.

image

@github-actions
Copy link

github-actions bot commented Dec 21, 2020

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1716, delta to last 3 avg.: -9%
  • 😶 query QPS at 31, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 1716 31
0.8.11 1894 31
0.8.10 1860 31
0.8.9 1914 29

Backed by latency-tracking. Further commits will update this comment.

@hanxiao
Copy link
Member Author

hanxiao commented Dec 21, 2020

@deepankarm it supports already. see https://docs.jina.ai/chapters/cli/jina-pea.html?highlight=uses

no it does not support

@github-actions
Copy link

Thanks for your contribution ❤️
💔 Unfortunately, this PR has one ore more bad commit messages, it can not be merged. To fix this problem, please refer to:

Note, other CI tests will not start until the commit messages get fixed.

This message will be deleted automatically when the commit messages get fixed.

@hanxiao hanxiao merged commit 52b5900 into master Dec 21, 2020
@hanxiao hanxiao deleted the fix-flow-loading branch December 21, 2020 17:39
@nan-wang nan-wang added this to the v0.9 Breaking Changes milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/flow size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants