Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix hubio typo #1531

Merged
merged 3 commits into from
Dec 22, 2020
Merged

style: fix hubio typo #1531

merged 3 commits into from
Dec 22, 2020

Conversation

yuanbit
Copy link
Contributor

@yuanbit yuanbit commented Dec 22, 2020

No description provided.

@yuanbit yuanbit requested a review from a team as a code owner December 22, 2020 13:50
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/docker labels Dec 22, 2020
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u also correct a typo in logger.error(f'user hasnot logged in. please login using command: {colored("jina hub login", attrs=["bold"])}')

@yuanbit
Copy link
Contributor Author

yuanbit commented Dec 22, 2020

Can u also correct a typo in logger.error(f'user hasnot logged in. please login using command: {colored("jina hub login", attrs=["bold"])}')

fixed

@github-actions
Copy link

github-actions bot commented Dec 22, 2020

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1689, delta to last 3 avg.: -6%
  • 🐢🐢 query QPS at 31, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 1689 31
0.8.12 1874 31
0.8.11 1663 33
0.8.10 1859 34

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1531 (939c283) into master (c2a096e) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
- Coverage   84.20%   84.14%   -0.06%     
==========================================
  Files         109      109              
  Lines        6184     6186       +2     
==========================================
- Hits         5207     5205       -2     
- Misses        977      981       +4     
Impacted Files Coverage Δ
jina/docker/hubapi.py 75.96% <100.00%> (ø)
jina/docker/hubio.py 69.29% <100.00%> (+0.08%) ⬆️
jina/parser.py 86.40% <100.00%> (+0.03%) ⬆️
jina/logging/sse.py 92.18% <0.00%> (-3.13%) ⬇️
jina/flow/base.py 88.66% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f1b3e...939c283. Read the comment docs.

@JoanFM JoanFM merged commit e04fde9 into master Dec 22, 2020
@JoanFM JoanFM deleted the fix-hubio-typo branch December 22, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/docker size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants