Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add crud numpy indexer #1550

Merged
merged 2 commits into from
Dec 28, 2020
Merged

fix: add crud numpy indexer #1550

merged 2 commits into from
Dec 28, 2020

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Dec 28, 2020

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner December 28, 2020 10:42
@JoanFM JoanFM marked this pull request as draft December 28, 2020 10:42
@github-actions
Copy link

This PR closes: #1549

1 similar comment
@github-actions
Copy link

This PR closes: #1549

@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Dec 28, 2020
@github-actions
Copy link

github-actions bot commented Dec 28, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 2012, delta to last 3 avg.: +4%
  • 😶 query QPS at 30, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 2012 30
0.8.15 1874 29
0.8.14 2007 30
0.8.13 1884 29

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM changed the title test: add test for github issue 1549 fix: add crud numpy indexer Dec 28, 2020
@JoanFM JoanFM marked this pull request as ready for review December 28, 2020 13:12
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1550 (615e209) into master (3f5a588) will increase coverage by 0.29%.
The diff coverage is 93.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
+ Coverage   84.37%   84.67%   +0.29%     
==========================================
  Files         108      109       +1     
  Lines        6311     6465     +154     
==========================================
+ Hits         5325     5474     +149     
- Misses        986      991       +5     
Impacted Files Coverage Δ
jina/executors/indexers/crud_vector.py 93.51% <93.51%> (ø)
jina/executors/indexers/vector.py 88.02% <100.00%> (-0.63%) ⬇️
jina/logging/sse.py 91.42% <0.00%> (-0.76%) ⬇️
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/flow/base.py 88.52% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.52% <0.00%> (+0.09%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66f14d...615e209. Read the comment docs.

Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see some of redudancy in CRUDBase and Crud, but given this is a temp solution, good to go

@hanxiao hanxiao merged commit 7999ef9 into master Dec 28, 2020
@hanxiao hanxiao deleted the test-1549 branch December 28, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/indexer executor/meta size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants