Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test hub usage github token #1560

Merged
merged 1 commit into from
Dec 29, 2020
Merged

fix: test hub usage github token #1560

merged 1 commit into from
Dec 29, 2020

Conversation

rutujasurve94
Copy link
Contributor

  • fixes the error TypeError("'str' object is not callable") in test_hub_usage

@github-actions
Copy link

github-actions bot commented Dec 29, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1933, delta to last 3 avg.: +1%
  • 😶 query QPS at 33, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1933 33
0.8.16 1921 34
0.8.15 1954 34
0.8.14 1852 34

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #1560 (adf9d61) into master (2425e4c) will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
+ Coverage   84.54%   84.94%   +0.40%     
==========================================
  Files         108      108              
  Lines        6346     6403      +57     
==========================================
+ Hits         5365     5439      +74     
+ Misses        981      964      -17     
Impacted Files Coverage Δ
jina/logging/profile.py 68.33% <0.00%> (-0.58%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/flow/base.py 89.03% <0.00%> (+0.08%) ⬆️
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/enums.py 96.52% <0.00%> (+0.09%) ⬆️
jina/peapods/peas/gateway/rest/__init__.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/vector.py 88.94% <0.00%> (+0.23%) ⬆️
jina/executors/rankers/__init__.py 93.33% <0.00%> (+0.31%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2425e4c...adf9d61. Read the comment docs.

@hanxiao hanxiao linked an issue Dec 29, 2020 that may be closed by this pull request
@hanxiao hanxiao merged commit 2ad570b into master Dec 29, 2020
@hanxiao hanxiao deleted the fix-hub-usage branch December 29, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_hub_build_push_push_again is either buggy or flaky
4 participants