Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): clean up codes in testing hubapi #1566

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

nan-wang
Copy link
Member

refactor(tests): clean up codes in testing hubapi

@nan-wang nan-wang requested a review from a team as a code owner December 30, 2020 15:40
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing labels Dec 30, 2020
@github-actions
Copy link

github-actions bot commented Dec 30, 2020

Latency summary

Current PR yields:

  • 😶 index QPS at 1631, delta to last 3 avg.: -2%
  • 😶 query QPS at 31, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1631 31
0.9.2 1694 31
0.9.1 1645 31
0.8.22 1696 31

Backed by latency-tracking. Further commits will update this comment.

JoanFM
JoanFM previously approved these changes Dec 30, 2020
Copy link
Member

@florian-hoenicke florian-hoenicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is failing because the access.yml is not defined right?
We could create it before running _fetch_access_token

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1566 (5a8376a) into master (7200c65) will increase coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1566      +/-   ##
==========================================
+ Coverage   83.98%   84.97%   +0.99%     
==========================================
  Files         127      127              
  Lines        6652     6711      +59     
==========================================
+ Hits         5587     5703     +116     
+ Misses       1065     1008      -57     
Impacted Files Coverage Δ
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/flow/base.py 86.58% <0.00%> (+0.10%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/vector.py 93.15% <0.00%> (+0.14%) ⬆️
jina/peapods/runtimes/asyncio/rest/__init__.py 93.18% <0.00%> (+0.15%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7200c65...6b57e3b. Read the comment docs.

@nan-wang nan-wang merged commit c68d2da into master Jan 6, 2021
@nan-wang nan-wang deleted the refactor-test-hubapi-access-token branch January 6, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants