Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix jinadruntime styling #1599

Merged
merged 3 commits into from
Jan 5, 2021
Merged

style: fix jinadruntime styling #1599

merged 3 commits into from
Jan 5, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 5, 2021

jinadruntime seems not need dict for __init__(args)

@hanxiao hanxiao requested a review from a team as a code owner January 5, 2021 20:28
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality component/peapod labels Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1703, delta to last 3 avg.: +0%
  • 😶 query QPS at 31, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1703 31
0.9.2 1710 32
0.9.1 1725 32
0.8.22 1675 32

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1599 (b3f3517) into master (692c2d9) will increase coverage by 0.92%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1599      +/-   ##
==========================================
+ Coverage   83.92%   84.84%   +0.92%     
==========================================
  Files         128      128              
  Lines        6674     6732      +58     
==========================================
+ Hits         5601     5712     +111     
+ Misses       1073     1020      -53     
Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 48.38% <44.44%> (ø)
jina/peapods/runtimes/jinad/api.py 54.66% <100.00%> (-0.31%) ⬇️
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/flow/base.py 86.58% <0.00%> (+0.10%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e28fe...9afc23c. Read the comment docs.

@hanxiao hanxiao merged commit 043a2bf into master Jan 5, 2021
@hanxiao hanxiao deleted the style-jinad branch January 5, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants