Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: safe comparison None #1604

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 5, 2021 22:44
@jina-bot jina-bot added size/XS area/testing This issue/PR affects testing labels Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 2032, delta to last 3 avg.: +2%
  • 😶 query QPS at 36, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 2032 36
0.9.2 1877 37
0.9.1 2019 37
0.8.22 2032 37

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1604 (35b5162) into master (44d850a) will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
+ Coverage   84.00%   84.87%   +0.86%     
==========================================
  Files         128      128              
  Lines        6665     6724      +59     
==========================================
+ Hits         5599     5707     +108     
+ Misses       1066     1017      -49     
Impacted Files Coverage Δ
jina/logging/sse.py 91.42% <0.00%> (-0.76%) ⬇️
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/executors/decorators.py 91.11% <0.00%> (-0.17%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/flow/base.py 86.58% <0.00%> (+0.10%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d850a...343d849. Read the comment docs.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 62d24c2 into master Jan 6, 2021
@nan-wang nan-wang deleted the refactor-save-comparison-none branch January 6, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants