refactor: moving jinad into daemon module of the core #1610
Conversation
hanxiao
commented
Jan 6, 2021
•
hanxiao
commented
- code
- test
- Dockerfile
- setup
- README (entrypoint changed, will rewrite in the next PR)
- API docs generation
- GH workflows
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
jina-bot
added
area/cicd
| def _start_fluentd(): | ||
| daemon_logger.info('starting fluentd') | ||
| cfg = pkg_resources.resource_filename('jina', 'resources/fluent.conf') | ||
| subprocess.Popen(['fluentd', '-c', cfg]) |
There was a problem hiding this comment.
Fluentd also ships as a daemon (td-agent), which means we can have systemctl manage it along with jinad. We can avoid having fluentd invocation inside python code, as this makes jinad unusable without fluentd command.
https://github.com/jina-ai/jinad/blob/main/scripts/deb-systemd.sh#L49
There was a problem hiding this comment.
let's handle this as another PR. right now it is too ahead to put systemctl together, the goal of this PR is to make the jinad usable in CICD.
There was a problem hiding this comment.
btw,
curl -L https://raw.githubusercontent.com/jina-ai/jinad/main/scripts/deb-systemd.sh | bashthis is good, but later will make it shorter, something like curl -L https://daemon-sh.jina.ai | bash
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
+ Coverage 83.98% 84.95% +0.96%
==========================================
Files 127 126 -1
Lines 6652 6648 -4
==========================================
+ Hits 5587 5648 +61
+ Misses 1065 1000 -65
Continue to review full report at Codecov.
|
