crud intergration tests: docidcache-centric

[cristianmtr]

Main integration tests for CRUD, focusing on using the new DocIDCache functionality

• Document content_hash incorrectly includes child chunks
• docs generator and testing it
• basic structure of tests & parameters
• UniquePbIndexer and UniqueVectorIndexer do not support delete and update
• issue with handling missing keys
• DocIDCache uses savepath / filename differently than most Indexers
• adding Delete and Update to CacheDriver

[github-actions]

Latency summary

Current PR yields:

• 😶 index QPS at 1962, delta to last 3 avg.: +3%
• 😶 query QPS at 36, delta to last 3 avg.: -4%

Breakdown

Version	Index QPS	Query QPS
current	1962	36
0.9.13	1829	37
0.9.12	1956	37

Backed by latency-tracking. Further commits will update this comment.

[JoanFM]

Now that I think, DocIDCache does not seem to be a proper name for a class that can cache based on content hash. I think this needs to be renamed DocCache.

[cristianmtr]

Now that I think, DocIDCache does not seem to be a proper name for a class that can cache based on content hash. I think this needs to be renamed DocCache.

I'll open a PR to refactor it everywhere and then will rebase

[codecov]

Codecov Report

Merging #1613 (9285166) into master (fa47adb) will decrease coverage by 0.20%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
- Coverage   85.03%   84.82%   -0.21%     
==========================================
  Files         133      133              
  Lines        6822     6828       +6     
==========================================
- Hits         5801     5792       -9     
- Misses       1021     1036      +15     

Impacted Files	Coverage Δ
jina/executors/indexers/keyvalue.py	98.68% <66.66%> (-1.32%)	⬇️
jina/drivers/cache.py	94.11% <100.00%> (+0.78%)	⬆️
jina/drivers/search.py	96.49% <100.00%> (+1.66%)	⬆️
jina/executors/indexers/cache.py	97.18% <100.00%> (+0.04%)	⬆️
jina/executors/indexers/vector.py	93.12% <100.00%> (ø)
jina/peapods/runtimes/jinad/api.py	75.65% <0.00%> (-11.19%)	⬇️
jina/flow/base.py	87.56% <0.00%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa47adb...9285166. Read the comment docs.

[JoanFM]

Problem seems to be that update is not clearing properly somehow blob shape. I think it may be more of a primitive types fault than the Update method itself, but it may have exposed the issue and it needs to be solved to continue

[JoanFM]

Just a minor thing,

However, I still think we should think how to better test for the index size without having such a complex code for testing

[cristianmtr]

Just a minor thing,

However, I still think we should think how to better test for the index size without having such a complex code for testing

I agree that the engineering of the tests shouldn't be so complex.

But on the other hand, as an advantage, we can see more clearly how changing some parameters in the cache would affect the size / output of the indexers. Having them as separate tests, with hard-coded apparently magic numbers, would have made the behavior more opaque.