Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache driver - update delete methods #1630

Closed
wants to merge 5 commits into from

Conversation

cristianmtr
Copy link
Contributor

@cristianmtr cristianmtr commented Jan 8, 2021

Required for CRUD integration tests
@florian-hoenicke @theUnkownName

Example of usage will come in #1613

This is only meant as a way of sharing the changes with the others that might need to test the cache driver update/delete as part of their suites

@cristianmtr cristianmtr requested a review from a team as a code owner January 8, 2021 17:14
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/driver labels Jan 8, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1637, delta to last 3 avg.: -3%
  • 😶 query QPS at 31, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1637 31
0.9.2 1701 31
0.9.1 1693 31

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM changed the title Feat: cache driver - update delete methods feat: cache driver - update delete methods Jan 8, 2021
@JoanFM
Copy link
Member

JoanFM commented Jan 8, 2021

Keep it as draft if it is not expected to be merged

@cristianmtr
Copy link
Contributor Author

It is expected to be merged

@JoanFM
Copy link
Member

JoanFM commented Jan 8, 2021

So unit tests must be added

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests must be added

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Jan 9, 2021
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #1630 (a61107b) into master (5edbce9) will decrease coverage by 42.90%.
The diff coverage is 12.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1630       +/-   ##
===========================================
- Coverage   84.00%   41.10%   -42.91%     
===========================================
  Files         126      126               
  Lines        6591     6591               
===========================================
- Hits         5537     2709     -2828     
- Misses       1054     3882     +2828     
Flag Coverage Δ
ci 41.10% <12.82%> (?)
integration 32.86% <12.82%> (?)
jinad 41.10% <12.82%> (?)
unit 41.10% <12.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/indexers/cache.py 34.28% <0.00%> (-60.39%) ⬇️
jina/drivers/cache.py 47.05% <7.69%> (-46.28%) ⬇️
jina/executors/indexers/vector.py 25.39% <13.33%> (-67.62%) ⬇️
jina/executors/indexers/keyvalue.py 36.48% <22.22%> (-63.52%) ⬇️
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/client.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/build.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/login.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/helloworld.py 0.00% <0.00%> (-100.00%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b67bce...a61107b. Read the comment docs.

@nan-wang
Copy link
Member

nan-wang commented Jan 9, 2021

Add some unit tests.

@cristianmtr
Copy link
Contributor Author

Add some unit tests.

Thanks for adding them, @nan-wang

Was not sure this should be merged actually. It was more for sharing a fix that might be required by other crud integration tests. I will get back to it after the stand up today where I'll ask if it's needed

@cristianmtr
Copy link
Contributor Author

Closing this as not needed. These changes will be added in #1613 . @nan-wang I will add your unit tests there

@nan-wang nan-wang deleted the feat-cache-driver-update-delete branch February 4, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants