-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache driver - update delete methods #1630
Conversation
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Keep it as draft if it is not expected to be merged |
It is expected to be merged |
So unit tests must be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests must be added
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
===========================================
- Coverage 84.00% 41.10% -42.91%
===========================================
Files 126 126
Lines 6591 6591
===========================================
- Hits 5537 2709 -2828
- Misses 1054 3882 +2828
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Add some unit tests. |
Thanks for adding them, @nan-wang Was not sure this should be merged actually. It was more for sharing a fix that might be required by other crud integration tests. I will get back to it after the stand up today where I'll ask if it's needed |
Required for CRUD integration tests
@florian-hoenicke @theUnkownName
Example of usage will come in #1613
This is only meant as a way of sharing the changes with the others that might need to test the cache driver update/delete as part of their suites