Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix deadlinks #1614

Merged
merged 2 commits into from
Jan 7, 2021
Merged

docs: fix deadlinks #1614

merged 2 commits into from
Jan 7, 2021

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Jan 6, 2021

This PR should fix all the deadlinks in docs:

  1. Ignore unused links in CHANGELOG.md.
  2. Ignore several local URIs, such as 0.0.0.0:[PORT].
  3. Fix unreachable links.

@bwanglzu bwanglzu requested a review from a team as a code owner January 6, 2021 22:01
@jina-bot jina-bot added size/S area/docs This issue/PR affects the docs labels Jan 6, 2021
@bwanglzu bwanglzu self-assigned this Jan 6, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1644, delta to last 3 avg.: +0%
  • 😶 query QPS at 27, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1644 27
0.9.2 1616 27
0.9.1 1623 27
0.8.22 1650 27

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1614 (4bc3a4a) into master (7200c65) will increase coverage by 1.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1614      +/-   ##
==========================================
+ Coverage   83.98%   85.04%   +1.05%     
==========================================
  Files         127      127              
  Lines        6652     6713      +61     
==========================================
+ Hits         5587     5709     +122     
+ Misses       1065     1004      -61     
Impacted Files Coverage Δ
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/vector.py 93.15% <0.00%> (+0.14%) ⬆️
jina/peapods/runtimes/asyncio/rest/__init__.py 93.18% <0.00%> (+0.15%) ⬆️
jina/flow/builder.py 73.91% <0.00%> (+0.28%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe3033...c7c2ee0. Read the comment docs.

Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need changelog in doc website. Please remove from excludelist

docs/conf.py Outdated Show resolved Hide resolved
@hanxiao hanxiao merged commit ed9be88 into master Jan 7, 2021
@hanxiao hanxiao deleted the docs-fix-deadlinks branch January 7, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants