Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: integration test after lint #1627

Merged
merged 2 commits into from
Jan 8, 2021
Merged

ci: integration test after lint #1627

merged 2 commits into from
Jan 8, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 8, 2021

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner January 8, 2021 06:49
@jina-bot jina-bot added size/XS area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 8, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1621, delta to last 3 avg.: -2%
  • 😶 query QPS at 31, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1621 31
0.9.2 1669 31
0.9.1 1676 31
0.8.22 1638 31

Backed by latency-tracking. Further commits will update this comment.

@hanxiao
Copy link
Member

hanxiao commented Jan 8, 2021

can you also change timeout from 30m to 40m?

@JoanFM
Copy link
Member Author

JoanFM commented Jan 8, 2021

can you also change timeout from 30m to 40m?

Done!

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #1627 (47db92b) into master (5edbce9) will increase coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1627      +/-   ##
==========================================
+ Coverage   84.00%   84.94%   +0.93%     
==========================================
  Files         126      126              
  Lines        6591     6650      +59     
==========================================
+ Hits         5537     5649     +112     
+ Misses       1054     1001      -53     
Impacted Files Coverage Δ
jina/logging/profile.py 69.84% <0.00%> (-0.56%) ⬇️
jina/executors/decorators.py 91.11% <0.00%> (-0.17%) ⬇️
jina/drivers/craft.py 100.00% <0.00%> (ø)
jina/types/ndarray/generic.py 100.00% <0.00%> (ø)
jina/drivers/encode.py 94.91% <0.00%> (+0.08%) ⬆️
jina/enums.py 96.59% <0.00%> (+0.09%) ⬆️
jina/jaml/__init__.py 95.93% <0.00%> (+0.09%) ⬆️
jina/clients/helper.py 94.00% <0.00%> (+0.12%) ⬆️
jina/executors/indexers/vector.py 93.15% <0.00%> (+0.14%) ⬆️
jina/peapods/runtimes/asyncio/rest/__init__.py 93.18% <0.00%> (+0.15%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edbce9...f0a2cf5. Read the comment docs.

@hanxiao hanxiao merged commit 9a89ab7 into master Jan 8, 2021
@hanxiao hanxiao deleted the ci-dep branch January 8, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants