Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some bugs in hubio #1631

Merged
merged 1 commit into from
Jan 9, 2021
Merged

fix: fix some bugs in hubio #1631

merged 1 commit into from
Jan 9, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 8, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner January 8, 2021 17:28
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/docker labels Jan 8, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1480, delta to last 3 avg.: -2%
  • 😶 query QPS at 25, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1480 25
0.9.2 1536 26
0.9.1 1498 25

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #1631 (065dbb3) into master (5edbce9) will decrease coverage by 42.90%.
The diff coverage is 9.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1631       +/-   ##
===========================================
- Coverage   84.00%   41.10%   -42.91%     
===========================================
  Files         126      126               
  Lines        6591     6590        -1     
===========================================
- Hits         5537     2709     -2828     
- Misses       1054     3881     +2827     
Flag Coverage Δ
ci 41.10% <9.75%> (?)
integration 32.86% <9.75%> (?)
jinad 41.10% <9.75%> (?)
unit 41.10% <9.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/docker/hubio.py 0.00% <0.00%> (-63.82%) ⬇️
jina/drivers/index.py 52.38% <ø> (-47.62%) ⬇️
jina/executors/indexers/cache.py 34.28% <0.00%> (-60.39%) ⬇️
jina/parsers/hub/pushpull.py 0.00% <0.00%> (-100.00%) ⬇️
jina/executors/indexers/vector.py 25.39% <10.00%> (-67.62%) ⬇️
jina/executors/indexers/keyvalue.py 36.48% <22.22%> (-63.52%) ⬇️
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/client.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/build.py 0.00% <0.00%> (-100.00%) ⬇️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b67bce...560ea35. Read the comment docs.

Copy link
Member

@florian-hoenicke florian-hoenicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to test the fixed bugs?

@JoanFM
Copy link
Member Author

JoanFM commented Jan 9, 2021

do we need to test the fixed bugs?

yes but do not have time and @alexcg1 needs this to push his app.

@JoanFM JoanFM merged commit 168a5e4 into master Jan 9, 2021
@JoanFM JoanFM deleted the hub-push-fix branch January 9, 2021 23:13
@alexcg1
Copy link
Member

alexcg1 commented Jan 9, 2021

I'll try pushing tomorrow morning and post results here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/docker size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants