Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: parallelize cicd #1633

Merged
merged 17 commits into from
Jan 8, 2021
Merged

refactor: parallelize cicd #1633

merged 17 commits into from
Jan 8, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 8, 2021

No description provided.

@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #1633 (146e32b) into master (8d63a8e) will decrease coverage by 39.71%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1633       +/-   ##
===========================================
- Coverage   80.84%   41.12%   -39.72%     
===========================================
  Files         126      126               
  Lines        6646     6587       -59     
===========================================
- Hits         5373     2709     -2664     
- Misses       1273     3878     +2605     
Flag Coverage Δ
cd ?
ci 41.12% <0.00%> (?)
integration 32.88% <0.00%> (?)
jinad 41.12% <0.00%> (?)
unit 41.12% <0.00%> (-39.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/index.py 52.38% <ø> (-47.62%) ⬇️
jina/executors/indexers/vector.py 25.39% <0.00%> (-67.87%) ⬇️
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/client.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/build.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/login.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/pushpull.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d63a8e...146e32b. Read the comment docs.

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not go in this direction

.github/workflows/cd.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1908, delta to last 3 avg.: +1%
  • 😶 query QPS at 35, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1908 35
0.9.2 1876 35
0.9.1 1839 35
0.8.22 1925 36

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao requested a review from a team as a code owner January 8, 2021 20:20
@hanxiao hanxiao requested review from yuanbit and JoanFM January 8, 2021 20:20
@jina-bot jina-bot added the area/setup This issue/PR affects setting up Jina label Jan 8, 2021
@jina-bot jina-bot added size/M and removed size/S labels Jan 8, 2021
@jina-bot jina-bot added area/core This issue/PR affects the core codebase component/driver labels Jan 8, 2021
@hanxiao hanxiao merged commit 2891033 into master Jan 8, 2021
@hanxiao hanxiao deleted the feat-parallel-ci branch January 8, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina component/driver component/executor executor/indexer size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants