Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daemon): miscellaneous fixes for logging, pod model, flow creation #1637

Merged
merged 6 commits into from
Jan 9, 2021

Conversation

deepankarm
Copy link
Contributor

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner January 9, 2021 15:07
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/peapod labels Jan 9, 2021
@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #1637 (88b3794) into master (2470c38) will increase coverage by 0.74%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
+ Coverage   84.82%   85.56%   +0.74%     
==========================================
  Files         126      126              
  Lines        6589     6589              
==========================================
+ Hits         5589     5638      +49     
+ Misses       1000      951      -49     
Flag Coverage Δ
cd ?
ci 85.56% <66.66%> (?)
core 84.88% <33.33%> (+0.06%) ⬆️
integration 42.52% <66.66%> (?)
jinad 45.21% <66.66%> (?)
unit 41.09% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 87.21% <ø> (+0.51%) ⬆️
jina/peapods/runtimes/jinad/api.py 74.34% <50.00%> (+19.07%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 100.00% <100.00%> (+51.61%) ⬆️
jina/logging/sse.py 95.31% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2470c38...88b3794. Read the comment docs.

@deepankarm deepankarm marked this pull request as draft January 9, 2021 15:39
@jina-bot jina-bot added the area/setup This issue/PR affects setting up Jina label Jan 9, 2021
@deepankarm deepankarm marked this pull request as ready for review January 9, 2021 16:31
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1745, delta to last 3 avg.: -3%
  • 😶 query QPS at 34, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1745 34
0.9.3 1817 34
0.9.2 1802 34
0.9.1 1828 34

Backed by latency-tracking. Further commits will update this comment.

@deepankarm
Copy link
Contributor Author

Fixes jina-ai/jinad#81

@hanxiao hanxiao merged commit d6d14f2 into master Jan 9, 2021
@hanxiao hanxiao deleted the daemon-fixes branch January 9, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/flow component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants