fix(daemon): fix some helper text for redocs #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jina-bot
added
size/S
area/cicd
deepankarm
reviewed
Jan 10, 2021
| @@ -208,6 +205,7 @@ async def _ping( | |||
| _, args, _ = ArgNamespace.get_parsed_args(kwargs, set_client_cli_parser()) | |||
| client = Client(args) | |||
| try: | |||
| # TODO: this introduces side-effect, need to be refactored. (2020.01.10) | |||
There was a problem hiding this comment.
Client & WebsocketClient need to be refactored to work as a context manager. This interface can tell the daemon client if the gateway server is alive.
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
+ Coverage 84.66% 84.69% +0.02%
==========================================
Files 128 128
Lines 6730 6730
==========================================
+ Hits 5698 5700 +2
+ Misses 1032 1030 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
jina-bot
added
size/M
area/core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.