New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: KVSearchDriver is_merge
should be False
by default
#1701
Conversation
is_merge
should be False
by default
Codecov Report
@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
+ Coverage 84.82% 85.06% +0.23%
==========================================
Files 133 133
Lines 6848 6856 +8
==========================================
+ Hits 5809 5832 +23
+ Misses 1039 1024 -15
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
63f4973
to
c4fee6e
Compare
Fixed a test |
This is to prevent duplicating the embedding and raising the reshaping error in Document (
ValueError: cannot reshape array of size 10 into shape (10,10)
)A more robust solution should be discussed in the future