Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KVSearchDriver is_merge should be False by default #1701

Merged
merged 1 commit into from Jan 15, 2021

Conversation

cristianmtr
Copy link
Contributor

This is to prevent duplicating the embedding and raising the reshaping error in Document (ValueError: cannot reshape array of size 10 into shape (10,10))

A more robust solution should be discussed in the future

@cristianmtr cristianmtr requested a review from a team as a code owner January 15, 2021 13:11
@cristianmtr cristianmtr changed the title fix: is merge should be False by default fix: KVSearchDriver is_merge should be False by default Jan 15, 2021
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/driver labels Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #1701 (b2275ba) into master (321a890) will increase coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1701      +/-   ##
==========================================
+ Coverage   84.82%   85.06%   +0.23%     
==========================================
  Files         133      133              
  Lines        6848     6856       +8     
==========================================
+ Hits         5809     5832      +23     
+ Misses       1039     1024      -15     
Impacted Files Coverage Δ
jina/flow/base.py 87.12% <33.33%> (-0.45%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 94.11% <33.33%> (-5.89%) ⬇️
jina/drivers/search.py 96.49% <100.00%> (ø)
jina/flow/builder.py 73.91% <100.00%> (+0.57%) ⬆️
jina/peapods/runtimes/jinad/api.py 86.84% <100.00%> (+11.18%) ⬆️
jina/peapods/runtimes/asyncio/rest/app.py 91.17% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321a890...c4fee6e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 15, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1641, delta to last 3 avg.: -1%
  • 😶 query QPS at 32, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1641 32
0.9.13 1663 32
0.9.12 1658 33

Backed by latency-tracking. Further commits will update this comment.

JoanFM
JoanFM previously approved these changes Jan 15, 2021
@cristianmtr
Copy link
Contributor Author

Fixed a test

@hanxiao hanxiao merged commit da2be57 into master Jan 15, 2021
@hanxiao hanxiao deleted the fix-kvsearch-is-merge branch January 15, 2021 19:35
hanxiao added a commit that referenced this pull request Jan 16, 2021
hanxiao added a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants