Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: KVSearchDriver is_merge should be False by default" #1706

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Jan 16, 2021

Reverts #1701 due to #1705

@hanxiao hanxiao requested a review from a team as a code owner January 16, 2021 00:07
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver labels Jan 16, 2021
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #1706 (8fc8a14) into master (da2be57) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         133      133           
  Lines        6856     6856           
=======================================
  Hits         5813     5813           
  Misses       1043     1043           
Impacted Files Coverage Δ
jina/drivers/search.py 96.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56f348...342d1da. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1605, delta to last 3 avg.: +0%
  • 😶 query QPS at 28, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1605 28
0.9.15 1594 28

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 2fb2a5e into master Jan 16, 2021
@hanxiao hanxiao deleted the revert-1701-fix-kvsearch-is-merge branch January 16, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants