Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doccache compatibility #2032

Merged
merged 3 commits into from Feb 24, 2021
Merged

fix: doccache compatibility #2032

merged 3 commits into from Feb 24, 2021

Conversation

cristianmtr
Copy link
Contributor

No description provided.

@cristianmtr cristianmtr requested a review from a team as a code owner February 24, 2021 10:23
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/indexer labels Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2032 (de20f32) into master (10e85cc) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
+ Coverage   88.56%   88.69%   +0.12%     
==========================================
  Files         200      200              
  Lines       10943    10947       +4     
==========================================
+ Hits         9692     9709      +17     
+ Misses       1251     1238      -13     
Flag Coverage Δ
daemon 50.45% <66.66%> (-0.01%) ⬇️
jina 89.11% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/indexers/cache.py 98.50% <100.00%> (+0.09%) ⬆️
jina/importer.py 80.42% <0.00%> (+0.85%) ⬆️
jina/peapods/runtimes/zmq/zed.py 92.90% <0.00%> (+1.41%) ⬆️
jina/flow/base.py 92.38% <0.00%> (+2.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e85cc...96b7c8a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 24, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1015, delta to last 3 avg.: +0%
  • 😶 query QPS at 14, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1015 14
1.0.4 1014 14
1.0.3 997 14

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit f45ec5d into master Feb 24, 2021
@nan-wang nan-wang deleted the fix-doccache-backwards branch February 24, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/indexer size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants