Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: take out peas hosts from cli #4171

Merged
merged 8 commits into from
Jan 13, 2022
Merged

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Jan 13, 2022

this PR taks out peas_hosts from core.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Jan 13, 2022
@github-actions github-actions bot added area/cli This issue/PR affects the command line interface component/flow labels Jan 13, 2022
@bwanglzu bwanglzu changed the title refactor: take out peas hosts parameter refactor: take out peas hosts from cli Jan 13, 2022
jina/peapods/pods/__init__.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #4171 (bae2cd3) into master (def0a12) will increase coverage by 1.02%.
The diff coverage is 89.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
+ Coverage   86.53%   87.56%   +1.02%     
==========================================
  Files         118      120       +2     
  Lines        8338     8570     +232     
==========================================
+ Hits         7215     7504     +289     
+ Misses       1123     1066      -57     
Flag Coverage Δ
daemon 40.94% <39.21%> (-1.17%) ⬇️
jina 86.77% <89.21%> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/parsers/base.py 60.00% <0.00%> (ø)
jina/types/request/__init__.py 100.00% <ø> (ø)
jina/proto/jina_pb2.py 58.10% <3.33%> (ø)
jina/clients/mixin.py 90.47% <25.00%> (ø)
jina/flow/builder.py 80.00% <33.33%> (ø)
jina/parsers/helper.py 45.18% <50.00%> (-0.34%) ⬇️
jina/peapods/runtimes/__init__.py 61.11% <54.54%> (ø)
jina/clients/base/helper.py 85.71% <60.00%> (ø)
jina/peapods/runtimes/head/__init__.py 91.85% <61.53%> (+4.06%) ⬆️
jina/clients/request/__init__.py 73.91% <66.66%> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1b605...bae2cd3. Read the comment docs.

@github-actions github-actions bot added size/M area/docs This issue/PR affects the docs labels Jan 13, 2022
@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1026, delta to last 2 avg.: -16%
  • 🐢🐢 query QPS at 16, delta to last 2 avg.: -31%
  • 🐢🐢 dam extend QPS at 28911, delta to last 2 avg.: -19%
  • 🐢🐢 avg flow time within 1.9815 seconds, delta to last 2 avg.: +42%
  • 🐎🐎 import jina within 0.4579 seconds, delta to last 2 avg.: +7%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1026 16 28911 1.9815 0.4579
2.6.4 1121 19 29665 1.6227 0.4665
2.6.3 1348 27 42564 1.149 0.3881

Backed by latency-tracking. Further commits will update this comment.

@bwanglzu bwanglzu marked this pull request as ready for review January 13, 2022 09:43
@github-actions
Copy link

📝 Docs are deployed on https://refactor-remove-peas-hosts--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 6f22e68 into master Jan 13, 2022
@JoanFM JoanFM deleted the refactor-remove-peas-hosts branch January 13, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/peapod size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants