Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: silence or minimize output of jina ping command #5476

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

girishc13
Copy link
Contributor

Goals:

@girishc13 girishc13 self-assigned this Dec 1, 2022
@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing labels Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #5476 (e664d67) into master (c2c6213) will increase coverage by 7.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5476      +/-   ##
==========================================
+ Coverage   78.65%   86.23%   +7.58%     
==========================================
  Files         101      101              
  Lines        6656     6656              
==========================================
+ Hits         5235     5740     +505     
+ Misses       1421      916     -505     
Flag Coverage Δ
jina 86.23% <100.00%> (+7.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/checker.py 85.36% <100.00%> (+85.36%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.61%) ⬆️
...ina/serve/runtimes/gateway/graph/topology_graph.py 99.48% <0.00%> (+1.03%) ⬆️
jina/serve/runtimes/worker/request_handling.py 91.14% <0.00%> (+1.56%) ⬆️
jina/clients/mixin.py 97.41% <0.00%> (+1.72%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.01% <0.00%> (+1.96%) ⬆️
jina/orchestrate/pods/container.py 87.19% <0.00%> (+1.97%) ⬆️
jina/parsers/helper.py 56.62% <0.00%> (+2.40%) ⬆️
jina/serve/runtimes/asyncio.py 86.08% <0.00%> (+2.60%) ⬆️
jina/jaml/helper.py 83.94% <0.00%> (+2.91%) ⬆️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JoanFM JoanFM merged commit 484d6b0 into master Dec 1, 2022
@JoanFM JoanFM deleted the feat-jina_cli-5474 branch December 1, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: silence or minimize output of jina ping command
2 participants