Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

feat: job #134

Merged
merged 9 commits into from
Aug 4, 2023
Merged

feat: job #134

merged 9 commits into from
Aug 4, 2023

Conversation

zac-li
Copy link
Member

@zac-li zac-li commented Jul 27, 2023

No description provided.

@zac-li zac-li force-pushed the feat-job branch 3 times, most recently from 05ec4b5 to a562391 Compare July 27, 2023 10:13
@zac-li zac-li changed the title Feat job feat: job Jul 27, 2023
Copy link
Contributor

@deepankarm deepankarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Do you plan to add an integration test for an end-to-end use case?

lcserve/__main__.py Outdated Show resolved Hide resolved
lcserve/__main__.py Outdated Show resolved Hide resolved
@zac-li zac-li marked this pull request as ready for review August 4, 2023 04:08
@zac-li
Copy link
Member Author

zac-li commented Aug 4, 2023

@deepankarm added a simple integration test and some docs

Copy link
Contributor

@deepankarm deepankarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@deepankarm deepankarm merged commit 9182fe7 into main Aug 4, 2023
9 checks passed
@deepankarm deepankarm deleted the feat-job branch August 4, 2023 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants