Find uses of Rows.Err when Rows is an interface #23
Conversation
|
@jingyugao could we merge this? |
| r.rowsTyp = types.NewPointer(resNamed) | ||
| r.skipFile = map[*ast.File]bool{} | ||
|
|
||
| for _, f := range funcs { | ||
| if r.noImportedDBSQL(f) { |
There was a problem hiding this comment.
Why delete? This will cost more time on lint.
There was a problem hiding this comment.
I mentioned it in the description of the PR.
for the github.com/jackc/pgx library that is commonly used for PostgreSQL, db/sql usually isn’t imported, so that noImportedDBSQL check was preventing the linter from seeing files with incorrect code.
In a lot of cases in my code, jackc/pgx isn’t even imported directly into files that are using those connections… it is just indirectly imported by accessing a connection pool object that is in another package.
There was a problem hiding this comment.
Can we check if it importgithub.com/jackc/pgx library?
|
|
||
| for i := 0; i < res.Len(); i++ { | ||
| flag = flag || types.Identical(res.At(i).Type(), r.rowsTyp) |
There was a problem hiding this comment.
I think line 93 should have same change. Otherwise for a function return pgx.Rows and it doesn't close the row, the lint will make it will make false positive
|
Could you plz add some test case for this change? |
I was attempting to use
rowserrcheckwithgithub.com/jackc/pgx/v4, and it didn't seem to be working. I started debugging the code, and I found a solution that seems to work.github.com/jackc/pgx/v4.Rowsis aninterfaceinstead of a concretestructtype, so I updated the code to support that as best as I could.I also had to update the
go.mod/go.sumfiles to get things to work with Go 1.16 code that I'm working on.EDIT:
noImportedDBSQLseemed to be excluding files that needed to be checked.jackc/pgxis rarely imported in the same files that need to callrows.Err().