Fix variable mutation in block #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mutating a variable from a block, the interpreter would call the `replace_variable` method, which would get a reference to the variable, remove it, and then add a new one. However, this method wasn't scope-map aware: While we were removing the correct variable from the outtermost scope, we were adding the new one in the inner scope. An easy fix is to instead mutate the variable we were originally getting.
CohenArthur
force-pushed
the
187-mutate-var-in-block
branch
from
a6a8dbd
to
be6af25
Compare
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
=======================================
Coverage 92.97% 92.98%
=======================================
Files 41 41
Lines 4227 4233 +6
=======================================
+ Hits 3930 3936 +6
Misses 297 297
Continue to review full report at Codecov.
|
SanderJSA
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mutating a variable from a block, the interpreter would call the
replace_variablemethod, which would get a reference to the variable,remove it, and then add a new one. However, this method wasn't scope-map
aware: While we were removing the correct variable from the outtermost
scope, we were adding the new one in the inner scope. An easy fix is to
instead mutate the variable we were originally getting.
Closes #187