[style] 다이얼로그 컴포넌트 제작 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ssoon-m
commented
Feb 7, 2024
There was a problem hiding this comment.
radix-ui 매우 많이 참고해서 구현을 했습니당
There was a problem hiding this comment.
해당 컴포넌트는 애니메이션동작이 완료될 때까지 마운트 해제를 지연해줍니다
Comment on lines
+206
to
+211
| function handler(childHanlder?: (e: React.MouseEvent<HTMLButtonElement>) => void) { | ||
| return (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| childHanlder?.(e); | ||
| others.onClick?.(e); | ||
| }; | ||
| } |
There was a problem hiding this comment.
asChild가 있으면 자식 컴포넌트로 렌더링을 대체합니다.
asChild props가 존재할 경우 해당 컴포넌트에 부착한 click handler와 자식 컴포넌트의 click handler모두 실행시키기 위한 메서드 입니다.
tolluset
approved these changes
Feb 7, 2024
tailwind.config.js
Outdated
| @@ -13,7 +13,19 @@ module.exports = { | |||
| colors: { | |||
| white: '#FFFFFF', | |||
| black: '#000000', | |||
| error: '#EB001C', | |||
| // error: '#EB001C', | |||
There was a problem hiding this comment.
빈 파일잉 있네영? 요거 지워야 되는 걸까여?
There was a problem hiding this comment.
앗 감사합니다 까먹고 못 지웠네요 ㅠㅠ
src/components/headless/Presence.tsx
Outdated
Comment on lines
86
to
90
| * prevAnimationName과 currentAnimationName이 다르다는 것은 애니메이션이 정상적으로 실행중이라는 뜻이다. | ||
| * | ||
| * state가 mounted상태가 됐을 때 | ||
| * prevAnimationName에 애니메이션이 실행 될 때의 이름을 저장한 상태 | ||
| * currentAnimationName엔 닫기 버튼을 누를 경우 실행되는 애니메이션 이름이 저장이 된 상태 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현한 것
구현하지 않은 것
동작 확인
2024-02-07.3.24.57.mov