Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop validation after first invalid field found #17

Conversation

yasuyuki-baba
Copy link

Sometimes, I don't want to stop the validation after found first invalid field.
Would you merge my changes?

@jirutka
Copy link
Owner

jirutka commented Nov 4, 2015

Good idea, could you please add some tests for the new behaviour?

@yasuyuki-baba
Copy link
Author

Hi, I added tests.

@ncsibra
Copy link

ncsibra commented Apr 19, 2017

Hi,

Is there any reason why it's not merged?
I would love to see this feature, but maybe the stopAfterFoundFirstInvalidField name is a little bit too verbose, failFast would be better.
Actually Hibernate Validator use the same wording, see Fail fast mode

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.09%) to 87.264% when pulling 6bf1aa3 on yasuyuki-baba:dont-stop-validation-after-first-invalid-field-found into df45b07 on jirutka:master.

@coveralls
Copy link

coveralls commented May 22, 2017

Coverage Status

Coverage decreased (-1.09%) to 87.264% when pulling 50db45a on yasuyuki-baba:dont-stop-validation-after-first-invalid-field-found into df45b07 on jirutka:master.

@yasuyuki-baba
Copy link
Author

Hi @ncsibra
Thank you your suggestion. I changed it to failFast

@jirutka How about?

@filipowm
Copy link

filipowm commented Jan 2, 2018

Hi @jirutka
Any update? It would be really nice to have this feature.

@FilipMalczak
Copy link

+1. I'm here to make this thread alive, since I find the feature useful.

@sarxos
Copy link

sarxos commented Jun 25, 2018

Hi @jirutka, can we have this merged please?

@mxw589
Copy link

mxw589 commented Jul 11, 2018

Hi @jirutka also would love to have this feature

@yasuyuki-baba
Copy link
Author

No longer needed this PR.
I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants