Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows safe filenames. #242

Merged
merged 3 commits into from
Oct 2, 2016
Merged

Windows safe filenames. #242

merged 3 commits into from
Oct 2, 2016

Conversation

jish
Copy link
Owner

@jish jish commented Oct 2, 2016

cf. #241
cc: @mpapis @rlgreen91

In our template directory we were using ERB tags for filenames. These
filenames do not behave well in Windows environments. Instead of using
ERB replacement we are using simple token substitution.

In our template directory we were using ERB tags for filenames. These
filenames do not behave well in Windows environments. Instead of using
ERB replacement we are using simple token substitution.
@coveralls
Copy link

Coverage Status

Coverage increased (+1.005%) to 97.26% when pulling 82bc896 on windows_safe_filenames into 3292193 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.007%) to 97.263% when pulling 824ceb6 on windows_safe_filenames into 3292193 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.005%) to 97.26% when pulling 4493b89 on windows_safe_filenames into 3292193 on master.

@jish jish merged commit 6af8e5b into master Oct 2, 2016
@jish jish deleted the windows_safe_filenames branch October 2, 2016 20:30
@mpapis
Copy link
Collaborator

mpapis commented Oct 3, 2016

sorry for late answer, jest this is a good fix, my guess is that %...% could be confused with dos variable evaluation, but I did not got chance to prove that, anyway this should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants