fix(screenshare): adapt to electron 17+ desktopCapturer.getSources #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with electron 17, desktopCapturer.getSources(options) is only available on the main process, not the renderer. See https://www.electronjs.org/docs/latest/breaking-changes#removed-desktopcapturergetsources-in-the-renderer
|
@saghul please review, I have successfully tested this, the deprecation warning is gone and the list of sources (eg screens and applications) still work. |
|
@saghul, does it look fine for you? I have already tested it successfully |
saghul
approved these changes
Feb 8, 2022
|
Sorry I missed this. LGTM! |
|
All good, thanks for the review. Its not that urgent. I will cut a release afterwards to have this ready for use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with electron 17, desktopCapturer.getSources(options) is
only available on the main process, not the renderer.
See https://www.electronjs.org/docs/latest/breaking-changes#removed-desktopcapturergetsources-in-the-renderer