Cache an exception result when retrieving config values #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigValueSupplier
caches the result of the retrieval so we don't re-run the retrieval code on every access, but if theConfigValueSuppler#doGet
chain throws, we bubble the exception up: aConfigDelegate
propagates the exception all the way up and anOptionalConfigDelegate
catches it and returns null. This behavior, though, breaks the caching inConfigValueSupplier
aslazy
doesn't cache the exception.This PR adds a
ConfigResult
class (which is a very simplified version of kotlin'sResult
, which still has issues) in which we can store the result of retrieval--be it a value or an exception.