Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tpc) disable ulpfec on chrome 96 #1816

Merged
merged 2 commits into from
Dec 8, 2021
Merged

fix(tpc) disable ulpfec on chrome 96 #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb998e4
fix(tpc) disable ulpfec on chrome 96
NewEraCracker Dec 8, 2021
af4ee7a
ref(tpc) add comment
NewEraCracker Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/RTC/TraceablePeerConnection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2824,6 +2824,13 @@ TraceablePeerConnection.prototype._createOfferOrAnswer = function(
.filter(caps => caps.mimeType.toLowerCase() !== `${MediaType.VIDEO}/${mimeType}`);
}

// Disable ulpfec on Google Chrome 96 because
// https://bugs.chromium.org/p/chromium/issues/detail?id=982793
if (browser.isChromiumBased() && browser.isVersionEqualTo('96')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to filter ulpfec completely for now? Are we using it in any way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, however from my testing this is specific to Google Chrome 96.

I leave this open to be extended in future if needed, as I am not seeing any bugs on Google Chrome 95, 97, Edge (even the one based on Chrome 96) and Opera.

Maybe the Google engineers screwed up something with their build !?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment here (with a link to the Chrome bug report) why this is needed, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jallamsetty1 done.

capabilities = capabilities
.filter(caps => caps.mimeType.toLowerCase() !== `${MediaType.VIDEO}/${CodecMimeType.ULPFEC}`);
}

try {
transceiver.setCodecPreferences(capabilities);
} catch (err) {
Expand Down
7 changes: 6 additions & 1 deletion service/RTC/CodecMimeType.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Enumeration of the codec mime types
* @type {{H264: string, OPUS: string, VP8: string, VP9: string}}
* @type {{H264: string, OPUS: string, ULPFEC: string, VP8: string, VP9: string}}
*/
const CodecMimeType = {
/**
Expand All @@ -13,6 +13,11 @@ const CodecMimeType = {
*/
OPUS: 'opus',

/**
* The ulpfec codec mime type.
*/
ULPFEC: 'ulpfec',

/**
* The vp8 codec mime type.
*/
Expand Down