Fixes receiving remove videos. #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial change was made in 912998b, but was not taking in consideration that all jitsi desktop video calls have a rtpTranslator, and that change broke incoming video. As this change is needed for jigasi, jigasi always sets useTranslator for the audio and that setting is only used in that case. fixes jitsi/jitsi#627 closes #505
gpolitis
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial change was made in 912998b, but was not taking in
consideration that all jitsi desktop video calls have a rtpTranslator,
and that change broke incoming video.
As this change is needed for jigasi, jigasi always sets useTranslator
for the audio and that setting is only used in that case.
fixes jitsi/jitsi#627
closes #505
Thanks @traud for finding it.