Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative path to chron file for stemma output #73

Closed
rbturnbull opened this issue Jul 21, 2023 · 2 comments · Fixed by #74
Closed

Relative path to chron file for stemma output #73

rbturnbull opened this issue Jul 21, 2023 · 2 comments · Fixed by #74

Comments

@rbturnbull
Copy link
Collaborator

Hi @jjmccollum - at the moment the stemma chron file is given as an absolute path in the stemma output. Is it possible for this to be a relative path from the stemma file so that if you move the directories (or post them online) the paths can still work?

@jjmccollum
Copy link
Owner

@rbturnbull It looks like collation.py already imports Path from the pathlib module, so I'm sure it's possible to get the relative path using that.

@jjmccollum
Copy link
Owner

@rbturnbull All fixed! The to_stemma method should now write the relative path to the chron file (using the system-appropriate path separator) in the main STEMMA output. This is passing the STEMMA CI test, but if you notice any other issues with this, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants