Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on first keypress in Hyprland > 0.36.0 (git master) #65

Closed
thefeiter opened this issue Mar 5, 2024 · 14 comments
Closed

Crash on first keypress in Hyprland > 0.36.0 (git master) #65

thefeiter opened this issue Mar 5, 2024 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@thefeiter
Copy link

Hi there,

after I built the binary and ran it it shows the keyboard as expected, but crashes as soon as I press a key.

The keystroke comes through.

Terminal output is:

./wvkbd-mobintl 
Initializing keyboard
Found 54 layouts
Found 2 layers
Resize 1920x120 1.000000, 55 layouts
xdg_surface@23: error 3: xdg_surface has never been configured
Wayland socket has been disconnected.
@System64fumo
Copy link
Contributor

Can confirm
Happens to me too
WAYLAND_DEBUG=1 log: wvkbd.log

@jacekpoz
Copy link

jacekpoz commented Mar 7, 2024

for me, when launched manually with --hidden, then toggling it (using SIGRTMIN) it works as expected

then toggling it twice to hide and bring it back up, it crashes in the exact same way as described

crashes the first time after unhiding when it's launched through the hyprland config

@thefeiter
Copy link
Author

v0.13 works for me

@proycon
Copy link
Collaborator

proycon commented Mar 9, 2024

I'm puzzled. I can't seem to replicate this problem, but since three people reported it surely something must be wrong. I've tried wvkbd v0.14.4 (corresponds to git master at this point) on Hyprland 0.35.0, wayfire 0.8.0 and sway 1.9, and all seem to work fine, also after keypress. Only wayfire 0.7.x is known to have issues currently (#52)

What compositor and version are you guys on? (and wvkbd version for completeness sake)

@jacekpoz I tried launching hidden and toggling as you described (on hyprland), but failed to reproduce it.

@proycon proycon self-assigned this Mar 9, 2024
@proycon proycon added bug Something isn't working help wanted Extra attention is needed labels Mar 9, 2024
@stacyharper
Copy link
Contributor

stacyharper commented Mar 9, 2024

Could someone post the output with WAYLAND_DEBUG=1 please?

@proycon
Copy link
Collaborator

proycon commented Mar 9, 2024

@stacyharper A log was provided by @AmirDahan already

@proycon
Copy link
Collaborator

proycon commented Mar 9, 2024

Ok, I managed to replicate it now. I upgraded from Hyprland 0.35 to Hyprland 0.36 (didn't land in Arch yet so I was one version behind) and that indeed breaks wvkbd as described in this issue.

@proycon proycon changed the title Crash on first keypress Crash on first keypress in Hyprland 0.36.0 Mar 9, 2024
@proycon
Copy link
Collaborator

proycon commented Mar 9, 2024

Correction, I'm on Hyprland git main, which is already ahead a bit of 0.36.. 0.36 does seem to work fine.. But that implies that you all are running the hyprland development version as well?

@proycon proycon changed the title Crash on first keypress in Hyprland 0.36.0 Crash on first keypress in Hyprland 0.36.0+ (git master) Mar 9, 2024
@stacyharper
Copy link
Contributor

stacyharper commented Mar 9, 2024

The problem seems that the xdg popup surface is not configured correctly by the compositor. In the log provided, we can see the xdg_surface@23.get_popup request, while the error is xdg_surface@23: error 3: xdg_surface has never been configured . Also, we never receive the xdg_popup@configure event.

Reading the Wayland documentation, I don't see where we could have done something wrong. Does Hyprland works correctly with popups created for zwlr_layer_surfaces?

@proycon proycon changed the title Crash on first keypress in Hyprland 0.36.0+ (git master) Crash on first keypress in Hyprland > 0.36.0 (git master) Mar 9, 2024
@vaxerski
Copy link

vaxerski commented Mar 9, 2024

why do you gotta create the popup before the ls is mapped... ugh

vaxerski added a commit to hyprwm/Hyprland that referenced this issue Mar 9, 2024
@vaxerski
Copy link

vaxerski commented Mar 9, 2024

I've fixed this, but fwiw, that's not good practice...

@proycon
Copy link
Collaborator

proycon commented Mar 9, 2024

Thanks!

@proycon proycon removed the help wanted Extra attention is needed label Mar 9, 2024
@jacekpoz
Copy link

jacekpoz commented Mar 9, 2024

updated hyprland to latest commit and wvkbd back to wvkbd-0.14.3, can confirm it works with no issues!

@System64fumo
Copy link
Contributor

Can confirm, It works fine now 👍

@proycon proycon closed this as completed Mar 9, 2024
lisuke pushed a commit to lisuke/Hyprland that referenced this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants