Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Feature: Add auto-complete query text suggestion #153

Merged
merged 13 commits into from
Mar 15, 2020

Conversation

jjw24
Copy link
Owner

@jjw24 jjw24 commented Feb 28, 2020

Context:
Query text suggestion to help users visualise the top suggested query and provide a better search experience.

Solution:
Auto-complete query text suggestion for top result that match the user's query text case insensitive.

When no query input:
image

During search:
image

@jjw24 jjw24 added the enhancement New feature or request label Feb 28, 2020
@jjw24 jjw24 self-assigned this Feb 28, 2020
@jjw24 jjw24 requested a review from theClueless March 1, 2020 09:04
@theClueless
Copy link
Collaborator

theClueless commented Mar 3, 2020

@jjw24 found a few issues while did a manual test (related to the way it is wired between the view and the VM and the registration to the results VM prop change).
I think we might be able to solve this in a simpler manner with a converter that get the selected result and the current query text and then just find the substring (and check for the action keyword using the original query in the result) do you think?

@jjw24
Copy link
Owner Author

jjw24 commented Mar 3, 2020

@theClueless action keyword needs to be included in the auto complete because users may use keyword in WebSearch plugin, eg. twitter as action keyword and * as global for searching google: query ''twitter Michael Jordan", text suggestion needs to cater for the action keyword 'twitter' as well as just searching Google for 'twitter Michael Jordan'.

I did try to go with a converter but the text suggestion wasnt reacting faster enough to typing, so this is the simplest implementation I could think of so far

@theClueless
Copy link
Collaborator

sorry I edited my response before seeing your response :)

@theClueless action keyword needs to be included in the auto complete because users may use keyword in WebSearch plugin, eg. twitter as action keyword and * as global for searching google: query ''twitter Michael Jordan", text suggestion needs to cater for the action keyword 'twitter' as well as just searching Google for 'twitter Michael Jordan'.

I did try to go with a converter but the text suggestion wasnt reacting faster enough to typing, so this is the simplest implementation I could think of so far

ok, make sense about the action keyword, odd that you had a perf issue with the converter.

Wox/MainWindow.xaml Outdated Show resolved Hide resolved
Wox/ViewModel/MainViewModel.cs Outdated Show resolved Hide resolved
Wox/ViewModel/MainViewModel.cs Outdated Show resolved Hide resolved
Wox/ViewModel/MainViewModel.cs Outdated Show resolved Hide resolved
Wox/ViewModel/MainViewModel.cs Outdated Show resolved Hide resolved
@jjw24 jjw24 requested a review from theClueless March 8, 2020 05:35
@jjw24
Copy link
Owner Author

jjw24 commented Mar 14, 2020

looks great! @theClueless lets get this through

Copy link
Collaborator

@theClueless theClueless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@theClueless theClueless merged commit b50f738 into dev Mar 15, 2020
@theClueless theClueless deleted the add_autocomplete_querytext branch March 15, 2020 10:54
@fabeit
Copy link

fabeit commented Sep 15, 2020

Is it possible to use autocomplete in a way similar to linux shell? It's very useful when wanting to search into a folder with a long name. For example hit tab and the highlighted results autocompletes.

@jjw24
Copy link
Owner Author

jjw24 commented Sep 19, 2020

Is it possible to use autocomplete in a way similar to linux shell? It's very useful when wanting to search into a folder with a long name. For example hit tab and the highlighted results autocompletes.

Fantastic idea, I have been wanting to implement something like this later. Was thinking something like an option which user can select to use tab to move down the result or auocomplete the result. Will be useful for Shell plugin as well when you dont want to retype the query from the dropdown list.

This fork is no longer under development except if it's critical fix. I will move this feature suggestion to Flow Launcher Flow-Launcher/Flow.Launcher#156.

@fabeit
Copy link

fabeit commented Sep 19, 2020

Is it possible to use autocomplete in a way similar to linux shell? It's very useful when wanting to search into a folder with a long name. For example hit tab and the highlighted results autocompletes.

Fantastic idea, I have been wanting to implement something like this later. Was thinking something like an option which user can select to use tab to move down the result or auocomplete the result. Will be useful for Shell plugin as well when you dont want to retype the query from the dropdown list.

This fork is no longer under development except if it's critical fix. I will move this feature suggestion to Flow Launcher Flow-Launcher/Flow.Launcher#156.

Sounds good! But can you tell me what is this feature then? "Auto-complete text suggestion" which is mentioned in the home page?

And does Flow Launcher differ from Wox?

@jjw24
Copy link
Owner Author

jjw24 commented Sep 19, 2020

Sounds good! But can you tell me what is this feature then? "Auto-complete text suggestion" which is mentioned in the home page?

So that auto-complete feature at this stage is more of a visual thing, I have yet had the time to fully implement it to your suggestion.

And does Flow Launcher differ from Wox?

Flow Launcher is different to Wox in terms of more features available and bugs are stamped out constantly. It only shares the basic fundamentals of Wox and is constantly evolving.

@fabeit
Copy link

fabeit commented Sep 19, 2020

Thanks, I will give it a go!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants