Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor compatibility fixup #58

Closed
wants to merge 2 commits into from

Conversation

malachib
Copy link

Changed two things:

  • CLang/ARM64 can't quite resolve unsigned long long == unsigned long despite them both being 64-bit unsigned integers. Comparing those two via numeric limits now
  • Presumed a default parameter for compressed_cache_detail of ieee754_binary64. If I got that wrong, my feelings won't be hurt and you can reject the PR :)

is_same for unsigned long long != unsigned long, despite both being 64 bit unsigned integers
@malachib
Copy link
Author

Two issues need attention before this is a viable PR:

  • I forgot use stdr namespace. Oops
  • I'm feeling there's a better way to compare the two than max() thought max() is reasonable

@jk-jeon
Copy link
Owner

jk-jeon commented Apr 16, 2024

I'm closing this because I came up with a different method of dealing with unsigned long long vs unsigned long issue in a recent commit.

@jk-jeon jk-jeon closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants