Add support for parsing an rrule string without frequency #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
rrulestr
fails to parse a simple RRule of"DTSTART:X"
.rrulevals
becomes empty andgroomRruleOptions
spreads an undefined value.dtstart
is parsed and only ever used if the parsed RRule string contains a frequency component ("RRULE:Y"
).This PR stores the parsed DTSTART as a field on an RRuleSet which may be changed using the new
dtstart
-setter. The DTSTART component is only printed ifRRuleSet._dtstart
is set andRRuleSet._rrule
is an empty array to avoid conflicting outputs.master
commitaddressing (- I hope the description here is enough)
yarn build
to rebuild thedist/
filesedit:
FYI, with the changes in e1146a3,
RRuleSet.tzid()
andRRuleSet.dtstart()
lose their type signatures. These may be recovered by upgrading TypeScript to 3.2+ with thestrictBindCallApply
-option.